Skip to content

manual_unwrap_or: Try suggesting map_or when unwrap_or fails#13127

Closed
tesuji wants to merge 1 commit intorust-lang:masterfrom
tesuji:suggest_map_or
Closed

manual_unwrap_or: Try suggesting map_or when unwrap_or fails#13127
tesuji wants to merge 1 commit intorust-lang:masterfrom
tesuji:suggest_map_or

Conversation

@tesuji
Copy link
Copy Markdown
Contributor

@tesuji tesuji commented Jul 19, 2024

changelog: [manual_unwrap_or]: Try suggesting map_or when unwrap_or fails

Next step of #13061

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jul 19, 2024

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 19, 2024
@Alexendoo
Copy link
Copy Markdown
Member

option_if_let_else covers this, manual_unwrap_or shouldn't suggest other methods

@tesuji
Copy link
Copy Markdown
Contributor Author

tesuji commented Jul 19, 2024

I think you're right. Since option_if_let_else is allowed by default, I cound't find out that this suggestion clashes with it.
Closing this PR then.

@tesuji tesuji closed this Jul 19, 2024
@tesuji tesuji deleted the suggest_map_or branch July 19, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants